ArkHost/HelixNotes
1
0
Fork 0
mirror of https://gitlab.com/ArkHost/HelixNotes.git synced 2026-07-24 07:45:57 +02:00
Code Issues Projects Releases Wiki Activity

Fix #157: don't flag notebook folder icons as orphaned attachments

Browse Source
This commit is contained in:
Yuri Karamian
2026-06-23 14:03:29 +02:00
parent 56dc0eefd7
commit 84ff75f223
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src-tauri/src/commands.rs
+9 -3
View File
@@ -1688,9 +1688,9 @@ pub struct OrphanAttachment {
// Conservatively find files in .helixnotes/attachments not referenced by ANY note. Scans every // Conservatively find files in .helixnotes/attachments not referenced by ANY note. Scans every
// .md in the vault (including .helixnotes/trash, so a restorable trashed note keeps its files) // .md in the vault (including .helixnotes/trash, so a restorable trashed note keeps its files)
// and matches each filename against both the raw note text and a percent-decoded copy (so a // plus notebook_icons.json, and matches each filename against both the raw text and a
// URL-encoded path like `my%20file.png` still counts as a reference). When in doubt a file is // percent-decoded copy (so a URL-encoded path like `my%20file.png` still counts as a reference).
// KEPT: a leftover orphan is harmless, a wrong deletion is not. // When in doubt a file is KEPT: a leftover orphan is harmless, a wrong deletion is not.
fn scan_orphaned_attachments(vault: &str) -> Result<Vec<(String, u64)>, String> { fn scan_orphaned_attachments(vault: &str) -> Result<Vec<(String, u64)>, String> {
let attachments_dir = operations::helixnotes_dir(vault).join("attachments"); let attachments_dir = operations::helixnotes_dir(vault).join("attachments");
if !attachments_dir.is_dir() { if !attachments_dir.is_dir() {
@@ -1719,6 +1719,12 @@ fn scan_orphaned_attachments(vault: &str) -> Result<Vec<(String, u64)>, String>
} }
} }
} }
// Folder icons live in attachments but are referenced here, not in notes. (#157)
let icons_path = operations::helixnotes_dir(vault).join("notebook_icons.json");
if let Ok(content) = std::fs::read_to_string(&icons_path) {
haystack.push_str(&content);
haystack.push('\n');
}
let decoded = percent_decode(&haystack); let decoded = percent_decode(&haystack);
let orphans = files let orphans = files
.into_iter() .into_iter()